refactor(interactive): Unify devcontainer.json of graphscope-dev and flex
#3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fail to install dependencies due to apache/incubator-graphar#515 |
zhanglei1949
commented
Jun 14, 2024
| @@ -330,7 +336,7 @@ write_env_config() { | |||
|
|
|||
| { | |||
| echo "export GRAPHSCOPE_HOME=${install_prefix}" | |||
| echo "export CMAKE_PREFIX_PATH=/opt/vineyard" | |||
| echo "export CMAKE_PREFIX_PATH=/opt/vineyard:/opt/graphscope/" | |||
There was a problem hiding this comment.
Needed by hiactor actor_codegen
siyuan0322
previously approved these changes
Jun 14, 2024
lidongze0629
force-pushed
the
rm-flex-dev-container
branch
from
a5ea0e0
to
fbb9099
Compare
Committed-by: xiaolei.zl from Dev container
lidongze0629
approved these changes
Jun 20, 2024
siyuan0322
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Flex use a different dev container image from graphscope-dev, remove the flex/.devcontainer.json
Fix #3864